Support Shanghai in Reference Tests #4900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for Shanghai in reference tests * Add Shanghai and Cancun milestones * Add "withdrawals" and "withdrawalsRoot" to json objects * Migrate to schedule by block header. Signed-off-by: Danno Ferrin <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
.../main/java/org/hyperledger/besu/ethereum/referencetests/BlockchainReferenceTestCaseSpec.java
Fixed
Show fixed
Hide fixed
Signed-off-by: Danno Ferrin <[email protected]>
macfarla
approved these changes
Jan 9, 2023
| @@ -175,6 +176,7 @@ public ReferenceTestBlockHeader( | |||
| baseFee != null ? Wei.fromHexString(baseFee) : null, // baseFee | |||
| Hash.fromHexString(mixHash), // mixHash | |||
| Bytes.fromHexStringLenient(nonce).toLong(), | |||
| // withdrawalsRoot == null ? Hash.EMPTY : Hash.fromHexString(withdrawalsRoot), | |||
There was a problem hiding this comment.
This is what withdrawals will do with it's code, once it's merged.
| @@ -157,6 +157,7 @@ | |||
| @JsonProperty("baseFeePerGas") final String baseFee, | |||
| @JsonProperty("mixHash") final String mixHash, | |||
| @JsonProperty("nonce") final String nonce, | |||
| @JsonProperty("withdrawalsRoot") final String withdrawalsRoot, | |||
Check notice
Code scanning / CodeQL
Useless parameter
macfarla
added a commit
to macfarla/besu
that referenced
this pull request
Jan 10, 2023
* Support Shanghai in Reference Tests Add support for Shanghai in reference tests * Add Shanghai and Cancun milestones * Add "withdrawals" and "withdrawalsRoot" to json objects * Migrate to schedule by block header. Signed-off-by: Danno Ferrin <[email protected]> * Add pending withdrawal code to test case spec Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]> Signed-off-by: Sally MacFarlane <[email protected]>
eum602
pushed a commit
to lacchain/besu
that referenced
this pull request
Nov 3, 2023
* Support Shanghai in Reference Tests Add support for Shanghai in reference tests * Add Shanghai and Cancun milestones * Add "withdrawals" and "withdrawalsRoot" to json objects * Migrate to schedule by block header. Signed-off-by: Danno Ferrin <[email protected]> * Add pending withdrawal code to test case spec Signed-off-by: Danno Ferrin <[email protected]> Signed-off-by: Danno Ferrin <[email protected]> Co-authored-by: Sally MacFarlane <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR description
Add support for Shanghai in reference tests
Signed-off-by: Danno Ferrin [email protected]
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR ifupdates are required.
Changelog